Update compiler option for community projects #7574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-options
branch
3 times, most recently
from
83e309e to
bb067db
Compare
liufengyun
force-pushed
the
fix-options
branch
from
bb067db to
78d5c44
Compare
|
@bishabosha Do we need the dotty-staging/scala-xml@fef2f87 change? It's not in the CI previously. |
|
No previously I made that commit and then pointed the community build at the previous commit because all it did was address warnings |
liufengyun
force-pushed
the
fix-options
branch
from
78d5c44 to
ad0eac4
Compare
anatoliykmetyuk
approved these changes
Nov 20, 2019
|
The removal of implicitConversions from the scalacOptions of some of the projects has lead to the CI output being truncated, the last line of https://dotty-ci.epfl.ch/lampepfl/dotty/2568/1/5 is:
This means we're missing the output of some project which is probably the root cause of #7607 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this test is green, we'll do a force push to the branch
dotty-community-buildofdotty-staging/*.