Fix #7413: Adjust singleton arguments for new conversions #7566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types of old-style implicit conversion methods were massaged in `adjustSingletonArgs` to become eligible for singleton arguments (which are widened, in order to get better cache hits ratios). The same is now done for new style Conversion instances.
smarter
approved these changes
Nov 18, 2019
| } | ||
| case _ => | ||
| tp.baseType(defn.ConversionClass) match | ||
| case app @ AppliedType(tycon, from :: to :: Nil) => |
There was a problem hiding this comment.
This could be:
Suggested change
| case app @ AppliedType(tycon, from :: to :: Nil) => | |
| case app @ AppliedType(tycon, from :: rest) => |
Then rest can be reused below instead of to :: Nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types of old-style implicit conversion methods were massaged in
adjustSingletonArgstobecome eligible for singleton arguments (which are widened, in order to get better cache hits
ratios). The same is now done for new style Conversion instances.