Adds -Xprint-phases #7508
Merged
Adds -Xprint-phases #7508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 6, 2019
|
contribution per https://gitter.im/lampepfl/dotty?at=5dc1a7c3a03ae1584f720b9d |
smarter
reviewed
Nov 6, 2019
| @@ -76,7 +76,8 @@ class ScalaSettings extends Settings.SettingGroup { | |||
| val XprintTypes: Setting[Boolean] = BooleanSetting("-Xprint-types", "Print tree types (debugging option).") | |||
| val XprintDiff: Setting[Boolean] = BooleanSetting("-Xprint-diff", "Print changed parts of the tree since last print.") | |||
| val XprintDiffDel: Setting[Boolean] = BooleanSetting("-Xprint-diff-del", "Print changed parts of the tree since last print including deleted parts.") | |||
| val XprintInline: Setting[Boolean] = BooleanSetting("-Xprint-inline", "Show where inlined code comes from") | |||
| val XprintInline: Setting[Boolean] = BooleanSetting("-Xprint-inline", "Show where inlined code comes from") | |||
| val XshowPhases: Setting[Boolean] = BooleanSetting("-Xprint-phases", "Print all compiler phases") | |||
There was a problem hiding this comment.
It's called -Xshow-phases in scalac so we might as well keep the same name:
Suggested change
| val XshowPhases: Setting[Boolean] = BooleanSetting("-Xprint-phases", "Print all compiler phases") | |
| val XshowPhases: Setting[Boolean] = BooleanSetting("-Xshow-phases", "Print all compiler phases") |
smarter
reviewed
Nov 6, 2019
|
|
||
| def phasesMessage: String = { | ||
| (new Compiler()).phases.map(phasegroup => { | ||
| if(phasegroup.length == 1) phasegroup.head.phaseName |
There was a problem hiding this comment.
Do a pattern match instead ? { case List(phase) => phase.phaseName; case phases => ... }
smarter
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes
-Xprint-phasesprints phases as inCompiler.scalaAlso, I snuck in
-Xand-Yin the main options list, as I thought that was useful but not worth a full PR, but I'm happy to revert that.