Fully compile primitive value classes #7447
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to drop compilation units for primitives after frontend, but this meant that a standard library compiled by dotty was not usable by dotty, because the primitive value classes were missing from the classpath: even though these classes are never loaded at runtime, they're unpickled at compile-time. Getting this to work required two changes: silence an error in refchecks (see comment) and turn off some computations in mixins that require cls.superClass to exist (primitives have no superclasses after erasure)
smarter
force-pushed
the
compile-primitives
branch
from
230467e to
47aa75d
Compare
odersky
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to drop compilation units for primitives after frontend, but
this meant that a standard library compiled by dotty was not usable by
dotty, because the primitive value classes were missing from the
classpath: even though these classes are never loaded at runtime,
they're unpickled at compile-time.
Getting this to work required two changes: silence an error in
refchecks (see comment) and turn off some computations in mixins that
require cls.superClass to exist (primitives have no superclasses after
erasure)