Make BigDecimalFromDigits extend FromDigits.Floating #7420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The given instance in FromDigits for BigDecimal was incorrectly ignoring exponents in number literals, This commit instead allows exponents in BigDecimal literals, and adds a test.
bishabosha
changed the title
smarter
approved these changes
Oct 13, 2019
| @@ -158,7 +158,7 @@ object FromDigits { | |||
| def fromDigits(digits: String, radix: Int): BigInt = BigInt(digits, radix) | |||
| } | |||
|
|
|||
| given BigDecimalFromDigits : FromDigits.Decimal[BigDecimal] { | |||
| given BigDecimalFromDigits : FromDigits.Floating[BigDecimal] { | |||
There was a problem hiding this comment.
This looks like the correct fix, but then in which case would you actually use FromDigits.Decimal ? It seems like it's not really useful on its own /cc @odersky
There was a problem hiding this comment.
I guess if there is no sparse representation for the implementation then it could make sense, but it's simple to convert from an exponent anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7419
The given instance in FromDigits for BigDecimal was incorrectly ignoring exponents in number literals.