Fix #7416: Don't emit signatures of fields of primitive types #7417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't emit signatures for private fields of primitive type
|
scalac has a very similar fix: scala/scala@e3bee06 |
smarter
approved these changes
Oct 13, 2019
Duhemm
approved these changes
Oct 13, 2019
| @@ -147,6 +147,12 @@ object TypeErasure { | |||
| def valueErasure(tp: Type)(implicit ctx: Context): Type = | |||
| erasureFn(isJava = false, semiEraseVCs = true, isConstructor = false, wildcardOK = false)(tp)(erasureCtx) | |||
|
|
|||
| /** Like value class erasure, but value classes erase to their underlying type erasure */ | |||
| def fullErasure(tp: Type)(implicit ctx: Context): Type = | |||
| valueErasure(tp) match | |||
There was a problem hiding this comment.
Was there some decision about mixing significant indentation syntax with braces syntax? (this match has no braces)
There was a problem hiding this comment.
I currently use indentation syntax for all code I touch to get a better feeling for it. If we decide not to do indentation, we can rewrite to braces automatically.
The reason not to convert to indentation wholesale is that is would destroy commit history.
|
I don't have time to port the test (we do not have an analogue of GenericSignaturesTest, it seems) but if someone could do it that would be welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't emit signatures for private fields of primitive type.
Maybe there's a better fix for this?