Skip to content

Join Tree and Pattern in TASTy Reflection #7344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Sep 30, 2019

Patterns where added as a way to have an abstraction over the trees that can be in pattern. It had a few shortcomings

  • Tmissmatch between TASTy file and TASTy reflect
  • Extra syntactic overhead
  • Harder to use in practice

@nicolasstucki nicolasstucki force-pushed the tasty-reflect-remove-patterns branch 2 times, most recently from afd51f6 to 3647b4f Compare September 30, 2019 14:34
@nicolasstucki nicolasstucki self-assigned this Sep 30, 2019
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-remove-patterns branch from 3647b4f to 594885f Compare September 30, 2019 19:44
@nicolasstucki nicolasstucki force-pushed the tasty-reflect-remove-patterns branch from 594885f to e23c0ad Compare September 30, 2019 19:53
@nicolasstucki nicolasstucki marked this pull request as ready for review October 1, 2019 07:54
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice simplification 👍

It would be good to put the motivation for this design change in the commit message.

@nicolasstucki nicolasstucki merged commit c1ba7e7 into scala:master Oct 1, 2019
@nicolasstucki nicolasstucki deleted the tasty-reflect-remove-patterns branch October 1, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants