Fix #7329: Fix assertions #7339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
reviewed
Sep 29, 2019
| @@ -1459,12 +1459,12 @@ class ReflectionCompilerInterface(val rootContext: core.Contexts.Context) extend | |||
| def Symbol_flags(self: Symbol)(given Context): Flags = self.flags | |||
|
|
|||
| def Symbol_tree(self: Symbol)(given Context): Tree = { | |||
| assert(!self.is(Case, butNot = Enum | Module)) | |||
| assert(!self.is(Case) || self.isClass) | |||
There was a problem hiding this comment.
case object Awill translate to a term A with the flag Case:
package <empty> {
final lazy module case <stable> <touched> val A: A$ = new A$()
final module case <noinits> <touched> class A$ <method> <stable> <touched>()
extends
Object(), _root_.scala.Product, _root_.scala.Serializable { this: A.type =>}
}The same for enums:
enum Color {
case Red, Green, Blue
}is transalted to
case <stable> <static> <enum> <touched> val Red: Color =
Color.$new(0, "Red")
case <stable> <static> <enum> <touched> val Green: Color =
Color.$new(1, "Green")
case <stable> <static> <enum> <touched> val Blue: Color =
Color.$new(2, "Blue")There was a problem hiding this comment.
There is no point having those assertions anyway. In the next PR Symbol_tree will return binds as well.
nicolasstucki
force-pushed
the
fix-#7329
branch
from
a9b9078 to
46a29f1
Compare
nicolasstucki
force-pushed
the
fix-#7329
branch
from
46a29f1 to
db93321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.