[doc] wording, parameter inline modifier #7337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe this is only of a personal taste. When I first read "can be marked `inline`" then I thought about an annotation. Since there is `@inline` it could be overlooked. Thus I suggest we rephrase it to "can have an `inline` modifier".
|
Out of curiosity, what import is needed for |
import scala.compiletime.code |
Co-Authored-By: Nicolas Stucki <nicolas.stucki@gmail.com>
Co-Authored-By: Nicolas Stucki <nicolas.stucki@gmail.com>
Co-Authored-By: Nicolas Stucki <nicolas.stucki@gmail.com>
Co-Authored-By: Nicolas Stucki <nicolas.stucki@gmail.com>
Co-Authored-By: Nicolas Stucki <nicolas.stucki@gmail.com>
nicolasstucki
approved these changes
Sep 30, 2019
|
Thanks @robstoll |
|
@nicolasstucki thanks for your time, next time I won't change something I am not sure about (e.g. remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this is only of a personal taste. When I first read "can be marked
inline" then I thought about an annotation. Since there is@inlineit could be overlooked. Thus I suggest we rephrase it to "can have aninlinemodifier".I rewrote
final valtovalas far as I understood this will no longer be supported in the future. I am not sure if the examples are still valid without thefinalthough