Cleanup reification of primitive liftables #7268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Sep 19, 2019
smarter
reviewed
Sep 19, 2019
nicolasstucki
force-pushed
the
do-not-hardcode-primitive-liftables
branch
from
f6bd430 to
77415fe
Compare
nicolasstucki
requested review from
liufengyun
and removed request for
liufengyun
nicolasstucki
force-pushed
the
do-not-hardcode-primitive-liftables
branch
from
244feb9 to
8b91123
Compare
smarter
reviewed
Sep 19, 2019
|
It was mostly to be able to rename them easily. I will remove the implicit search. |
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
do-not-hardcode-primitive-liftables
branch
from
4adfcb3 to
186feba
Compare
smarter
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.