Don't add lower bounds of abstract types to the implicit scope #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix/implicit-scope-bounds
branch
from
87b76fc to
430609f
Compare
As the spec[1] says: "The parts of a type T are [...] if T is an abstract type, the parts of its upper bound;" [1]: http://www.scala-lang.org/files/archive/spec/2.11/07-implicits.html#implicit-parameters
smarter
force-pushed
the
fix/implicit-scope-bounds
branch
from
430609f to
0efa171
Compare
|
/rebuild |
|
It times out after three minutes... Could you build and test locally? |
|
All tests pass locally. |
|
/rebuild |
|
@adriaanm : any idea why the builds keep getting aborted on Jenkins? |
|
/rebuild |
|
LGTM |
odersky
added a commit
that referenced
this pull request
Jul 15, 2015
Don't add lower bounds of abstract types to the implicit scope
|
We set the timeout to 0 on Jenkins to disable time outs. It turns out 0 == 3 modulo Jenkins-logic... The other issues you may have seen was due to running out of disk space, because we are now running the community build on the new CI. This should also be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the spec says:
Review by @odersky .