Fix #7137: Do not import Predef.any2stringadd by default #7164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#7137
branch
6 times, most recently
from
b7c4751 to
a2903fa
Compare
nicolasstucki
commented
Sep 4, 2019
| @tu lazy val ScalaPredefModule: Symbol = ctx.requiredModule("scala.Predef") | ||
| @tu lazy val ScalaPredefModule: Symbol = { | ||
| val mod = ctx.requiredModule("scala.Predef") | ||
| mod.infoOrCompleter match { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nicolasstucki
force-pushed
the
fix-#7137
branch
4 times, most recently
from
ae893dc to
1f5e4a3
Compare
nicolasstucki
force-pushed
the
fix-#7137
branch
from
1f5e4a3 to
01a9b12
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nicolasstucki
force-pushed
the
fix-#7137
branch
3 times, most recently
from
4279243 to
12882cc
Compare
This changes the default root import from `import scala.Predef._`
to `import scala.Predef.{ _, any2stringadd => _ }`.
nicolasstucki
force-pushed
the
fix-#7137
branch
from
12882cc to
1903b4a
Compare
nicolasstucki
changed the title
implicit modifier from Predef.any2stringadd
|
Reimplemented. Now modifies the root import. |
nicolasstucki
requested review from
liufengyun
and removed request for
odersky
liufengyun
approved these changes
Sep 12, 2019
| // selectors: { _, any2stringadd => _ } | ||
| val selectors = untpd.Ident(nme.WILDCARD) :: | ||
| Thicket(untpd.Ident(nme.any2stringadd) :: untpd.Ident(nme.WILDCARD) :: Nil) :: | ||
| Nil |
bishabosha
reviewed
Sep 12, 2019
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 15, 2019
smarter
added a commit
that referenced
this pull request
Sep 15, 2019
Fix sbt scripted test after #7164
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default root import from
import scala.Predef._to
import scala.Predef.{ _, any2stringadd => _ }.