Skip to content

Fix #7107: Avoid assertion that gets invalidated by illegal code #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

Fix #7107: Avoid assertion that gets invalidated by illegal code #7143

merged 1 commit into from
Sep 2, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 30, 2019

No description provided.

@odersky odersky requested a review from biboudis August 30, 2019 15:16
biboudis
biboudis approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@biboudis biboudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me some time to parse the intention of the comment which mentioned a negated assertion condition, followed by comment on its falsified state which happens on a neg test but LGTM otherwise. 🙈

@biboudis biboudis merged commit 518c426 into scala:master Sep 2, 2019
@biboudis biboudis deleted the fix-#7107 branch September 2, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biboudis biboudis biboudis approved these changes

Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @biboudis