-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow infix operators at start of line #7031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:
- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
e7f51f8
to
de5ea29
Compare
The Dotty compiler gives a warning under -language:Scala2 if the interpretation of a leading infix operator changes. E.g for c ! "hello"
! "world" you get:
It would be good if Scala 2.14 could make the same situation an error. Then it would be easy to upgrade to the new meaning, without risk of breaking changes. |
de5ea29
to
228b3ca
Compare
This PR is now broken out from #7024, since it is independent, and apparently less controversial. |
228b3ca
to
93fd8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, LGTM
// force a NEWLINE a after current token if it is on its own line | ||
lookahead.nextToken() | ||
canStartExpressionTokens.contains(lookahead.token) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove the field allowLeadingInfixOperators
, all the tests pass. However, the field makes a semantic difference for the following program:
@main def Test = {
val a = 5
val x = 1
+ //
`a` * 6
assert(x == 1)
}
Maybe add the code above as a run test.
The behavior is not covered by the tests in scala#7031
Examples:
Based on #7024.