Skip to content

Allow infix operators at start of line #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 12, 2019

Examples:

val x = 1
  + 2
  + 3

val condition = 
      x > 0
  ||  xs.exists(_ > 0)
  ||  xs.isEmpty

Based on #7024.

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Add" instead of "Added")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

@odersky
Copy link
Contributor Author

odersky commented Aug 12, 2019

The Dotty compiler gives a warning under -language:Scala2 if the interpretation of a leading infix operator changes. E.g for

  c ! "hello"
    ! "world"

you get:

14 |    ! "world"
   |    ^
   |Line starts with an operator;
   |it is now treated as a continuation of the expression on the previous line,
   |not as a separate statement.

It would be good if Scala 2.14 could make the same situation an error. Then it would be easy to upgrade to the new meaning, without risk of breaking changes.

@odersky
Copy link
Contributor Author

odersky commented Aug 22, 2019

This PR is now broken out from #7024, since it is independent, and apparently less controversial.

Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

// force a NEWLINE a after current token if it is on its own line
lookahead.nextToken()
canStartExpressionTokens.contains(lookahead.token)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove the field allowLeadingInfixOperators, all the tests pass. However, the field makes a semantic difference for the following program:

@main def Test = {
  val a = 5
  val x = 1
    + //
    `a` * 6

  assert(x == 1)
}

Maybe add the code above as a run test.

@odersky odersky merged commit a6b56a1 into scala:master Aug 25, 2019
@odersky odersky deleted the change-statseps branch August 25, 2019 08:29
liufengyun added a commit to dotty-staging/dotty that referenced this pull request Aug 25, 2019
The behavior is not covered by the tests in

scala#7031
@anatoliykmetyuk anatoliykmetyuk added this to the 0.18 Tech Preview milestone Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants