Skip to content

Fix #7028: Fix lines method of SourcePosition #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Aug 12, 2019

We now get:

- [E008] Member Not Found Error: i7028.scala:3:5 ------------------------------
2 |  "abc"
3 |    .foo       // error
  |  ^
  |  value foo is not a member of String - did you mean String("abc").+?
-- [E008] Member Not Found Error: i7028.scala:6:5 ------------------------------
5 |  "abc"
6 |    .bar.baz   // error
  |  ^
  |  value bar is not a member of String - did you mean String("abc").+?
-- [E008] Member Not Found Error: i7028.scala:9:5 ------------------------------
8 |  "abc"
9 |    .bar       // error
  |  ^
  |  value bar is not a member of String - did you mean String("abc").+?
three errors found

This looks fine. The current convention is that the ^ points at the start of the range in the first line.
It is hard to combine that with an indicator where the last line ends. So this part is left for future work,
if we decide to reorganize the way positions are presented.

and make it return a range.
@anatoliykmetyuk anatoliykmetyuk merged commit 76dabb9 into scala:master Aug 12, 2019
@anatoliykmetyuk anatoliykmetyuk deleted the fix-#7028 branch August 12, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants