Fix #6997: Adapt quote type direct aliase to type splice #7005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#6997
branch
from
c041e2b to
6e20e72
Compare
odersky
requested changes
Aug 19, 2019
| @@ -112,6 +112,10 @@ class PCPCheckAndHeal(@constructorOnly ictx: Context) extends TreeMapWithStages( | |||
| if (tp.isTerm) | |||
| ctx.error(i"splice outside quotes", pos) | |||
| tp | |||
| case tp: TypeRef if tp.prefix.derivesFrom(defn.QuotedTypeClass) && tp.name.toString == "T" => | |||
There was a problem hiding this comment.
It's fragile and un-idiomatic to compare a name. If we have to do this, the name needs to be forge-proof (i.e. use $ characters in it, and there should be a fat comment in QuotedTypeClass that the type parameter name cannot be changed.
But I hope we do not need to do that, and that this works instead:
case tp: TypeRef if tp.symbol == defn.QuotedTypeClass.typeParams.headThere was a problem hiding this comment.
It worked with that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.