Rebase scalatest community build on scalatest/3.1.x #7003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
update-scalatest
branch
from
ff668d5 to
dadd1c2
Compare
|
We have some new issue with a [info] - should be used when GenSeq is being compared with shouldEqual matcher *** FAILED *** (2 milliseconds)
[info] Expected exception org.scalatest.exceptions.TestFailedException to be thrown, but java.lang.NoClassDefFoundError was thrown (DifferSpec.scala:429)
[info] org.scalatest.exceptions.TestFailedException:
[info] at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info] at org.scalatest.funspec.AnyFunSpec.newAssertionFailedException(AnyFunSpec.scala:1631)
[info] at org.scalatest.Assertions.intercept(Assertions.scala:762)
[info] at org.scalatest.funspec.AnyFunSpec.intercept(AnyFunSpec.scala:1631)
[info] at org.scalactic.DifferSpec.$init$$$anonfun$132$$anonfun$13(DifferSpec.scala:430)
[info] at org.scalatest.funspec.AnyFunSpecLike.org$scalatest$funspec$AnyFunSpecLike$ItWord$$_$apply$$anonfun$1(AnyFunSpecLike.scala:167)
[info] at org.scalatest.Transformer.apply$$anonfun$1(Transformer.scala:22)
[info] at org.scalatest.OutcomeOf.outcomeOf(OutcomeOf.scala:85)
[info] at org.scalatest.OutcomeOf$.outcomeOf(OutcomeOf.scala:104)
[info] at org.scalatest.Transformer.apply(Transformer.scala:22)
[info] at org.scalatest.Transformer.apply(Transformer.scala:21)
[info] at org.scalatest.funspec.AnyFunSpecLike$$anon$1.apply(AnyFunSpecLike.scala:456)
[info] at org.scalatest.TestSuite.withFixture(TestSuite.scala:196)
[info] at org.scalatest.funspec.AnyFunSpec.withFixture(AnyFunSpec.scala:1631)
[info] at org.scalatest.funspec.AnyFunSpecLike.invokeWithFixture$1(AnyFunSpecLike.scala:462)
[info] at org.scalatest.funspec.AnyFunSpecLike.runTest$$anonfun$1(AnyFunSpecLike.scala:466)
[info] at org.scalatest.SuperEngine.runTestImpl(Engine.scala:307)
[info] at org.scalatest.funspec.AnyFunSpecLike.runTest(AnyFunSpecLike.scala:466)@liufengyun, could you investigate this one? |
|
OK, I'll have a look |
|
Cool. I see that you could revert the workarounds I added previously. We can probably squash dotty-staging/scalatest@6a4c896 and dotty-staging/scalatest@d8c3df8 with dotty-staging/scalatest@db67eb2. This would minimize the diff with |
|
Note that this uses the scalatest branch https://github.com/dotty-staging/scalatest/commits/dotty-community-build. |
liufengyun
force-pushed
the
update-scalatest
branch
from
dc30e3c to
ba2c032
Compare
anatoliykmetyuk
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.