Remove NamedTermRef and NamedTypeRef #7001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
join-type-and-term-ref-api
branch
3 times, most recently
from
5317da0 to
303e05c
Compare
Make it closer to NamedTermRef extractor
nicolasstucki
force-pushed
the
join-type-and-term-ref-api
branch
from
303e05c to
56c877c
Compare
Make it closer to NamedTypeRef extractor
Align extractors with TypeRef and TermRef
liufengyun
approved these changes
Aug 8, 2019
| def unapply(typeOrBounds: TypeOrBounds) given (ctx: Context): Option[(Symbol, TypeOrBounds /* Type | NoPrefix */)] = | ||
| internal.matchTermRef_unapply(typeOrBounds) | ||
| def unapply(typeOrBounds: TypeOrBounds) given (ctx: Context): Option[(TypeOrBounds /* Type | NoPrefix */, String)] = | ||
| internal.matchTermRef(typeOrBounds).map(x => (x.qualifier, x.name)) |
There was a problem hiding this comment.
Maybe return Symbol instead of Name --- programmers can easily get name from symbol.
There was a problem hiding this comment.
The symbol is not part of the type structure. It is also more efficient to get the symbol directly with termSymbol rather than boxing it with the qualifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.