Improve handling of Java annotations, avoid cycles #6978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that Java annotations cannot have type parameters, so part of this method was dead code.
Previously, we made up default getters that were then recognized by the backend, this has at least two downsides: - Creating the default getters requires forcing the info of all the methods in the annotation class, this might lead to cycles. - This scheme leaks into Tasty, and therefore becomes part of the Tasty specification, this is inelegant at best. In the new scheme, no default getters are created, instead we special-case the typing of annotation constructors: when an argument for the annotation constructor is missing, we replace it with a typed wildcard Ident if the corresponding parameter is known to have a default value. The Tasty spec and the backend need to be aware of this usage of wildcard, but that's easier to specify and to implement than default getters.
Compute the info of synthesized Java annotation constructors lazily, just like the info of all the other members created by ClassfileParser. Thanks to noti0na1 for the initial investigation and test case!
odersky
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.