Skip to content

Rename TASTy reflect Kernel to Internal #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2019
Merged

Rename TASTy reflect Kernel to Internal #6975

merged 3 commits into from
Aug 1, 2019

Conversation

nicolasstucki
Copy link
Contributor

The intension is to make it clear to the users of tasty.Reflection that this is for internal use only.

@nicolasstucki nicolasstucki requested a review from liufengyun July 31, 2019 14:39
@nicolasstucki
Copy link
Contributor Author

Also remove the confusion between Core and Kernel

@nicolasstucki nicolasstucki self-assigned this Jul 31, 2019
@nicolasstucki nicolasstucki marked this pull request as ready for review July 31, 2019 15:35
liufengyun
liufengyun approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@nicolasstucki nicolasstucki merged commit b25d17c into scala:master Aug 1, 2019
@nicolasstucki nicolasstucki deleted the rename-tasty-kernel branch August 1, 2019 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun