Skip to content

Fix #6972: Parially revert c53f465524597bad481f4930eaeaae8ae953e1a7 #6973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 31, 2019

The issue is that inherited main methods such as the one from App are not considered main method with this stricter condition. c53f465

This currently breaks the nightly build.

@anatoliykmetyuk
Copy link
Contributor

Was it not the commit that enabled @main methods from SBT?

@nicolasstucki nicolasstucki marked this pull request as ready for review July 31, 2019 10:53
@nicolasstucki nicolasstucki requested a review from odersky July 31, 2019 10:53
@nicolasstucki
Copy link
Contributor Author

The part that enables the @main is c53f465#diff-1e6b86ac307cd27014c80b0d1456e17aR233 which was not reverted

@anatoliykmetyuk
Copy link
Contributor

That line is still affected: https://github.com/lampepfl/dotty/blob/c53f465524597bad481f4930eaeaae8ae953e1a7/compiler/src/dotty/tools/dotc/config/Platform.scala#L47

We just need to write the tests for SBT compat at some point.

@nicolasstucki
Copy link
Contributor Author

The code in this PR has a condition that is less restricive. It will just accept more method as main methods.

@smarter
Copy link
Member

smarter commented Jul 31, 2019

But that's too imprecise, it will consider a main method in a trait to be a valid entry point even though such a method is not static.

@nicolasstucki
Copy link
Contributor Author

Yes, it is imprecise and intended as a quick fix for the CI to pass.

@nicolasstucki nicolasstucki merged commit 5bdab50 into scala:master Jul 31, 2019
@nicolasstucki nicolasstucki deleted the fix-#6972 branch July 31, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants