Fix #6972: Parially revert c53f465524597bad481f4930eaeaae8ae953e1a7 #6973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it not the commit that enabled @main methods from SBT? |
|
The part that enables the |
|
That line is still affected: https://github.com/lampepfl/dotty/blob/c53f465524597bad481f4930eaeaae8ae953e1a7/compiler/src/dotty/tools/dotc/config/Platform.scala#L47 We just need to write the tests for SBT compat at some point. |
|
The code in this PR has a condition that is less restricive. It will just accept more method as |
|
But that's too imprecise, it will consider a main method in a trait to be a valid entry point even though such a method is not static. |
|
Yes, it is imprecise and intended as a quick fix for the CI to pass. |
smarter
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that inherited
mainmethods such as the one fromAppare not considered main method with this stricter condition. c53f465This currently breaks the nightly build.