Skip to content

Add quoted type patterns #6930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 10, 2019
Merged

Add quoted type patterns #6930

merged 13 commits into from
Sep 10, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 25, 2019 •
edited
Loading

Introduces quote patterns on quoted types. It handles a case '[...] => the same way case '{...} => with the distinction that the pattern passed to the Matcher is of type quoted.Type instead of quoted.Expr.

Also fixed constraint approximation for contravariant type splices.

@nicolasstucki nicolasstucki force-pushed the add-type-quote-patterns branch from 319e7b9 to 653c143 Compare July 25, 2019 07:38
@nicolasstucki nicolasstucki self-assigned this Jul 25, 2019
@nicolasstucki nicolasstucki mentioned this pull request Jul 25, 2019
Closed
16 tasks
@nicolasstucki nicolasstucki force-pushed the add-type-quote-patterns branch 3 times, most recently from 09ba4c3 to 39cf74b Compare August 6, 2019 12:40
@nicolasstucki nicolasstucki marked this pull request as ready for review August 6, 2019 17:21
@nicolasstucki nicolasstucki requested a review from odersky August 6, 2019 17:25
@nicolasstucki nicolasstucki force-pushed the add-type-quote-patterns branch from 39cf74b to dd81033 Compare August 8, 2019 07:52
@nicolasstucki
Copy link
Contributor Author

Rebased

odersky
odersky previously requested changes Aug 23, 2019
View reviewed changes
@odersky odersky assigned nicolasstucki and unassigned odersky Aug 23, 2019
@nicolasstucki nicolasstucki force-pushed the add-type-quote-patterns branch from dd81033 to 7ac1dba Compare August 26, 2019 09:51
@nicolasstucki nicolasstucki requested a review from odersky August 26, 2019 10:43
odersky
odersky reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for choice of symbols =#=, =%=. But if we want to make this PR part of the release I am also OK with fixing that part separately later.

@odersky odersky assigned nicolasstucki and unassigned odersky Aug 30, 2019
@nicolasstucki
Copy link
Contributor Author

Let's merge it after the release.

@nicolasstucki nicolasstucki added this to the 0.19 Tech Preview milestone Aug 30, 2019
@nicolasstucki nicolasstucki force-pushed the add-type-quote-patterns branch from 7ac1dba to f1a4019 Compare September 2, 2019 09:18
@nicolasstucki
Copy link
Contributor Author

Rebased

@nicolasstucki nicolasstucki removed this from the 0.19 Tech Preview milestone Sep 6, 2019
@nicolasstucki nicolasstucki merged commit 7423d31 into scala:master Sep 10, 2019
@nicolasstucki nicolasstucki deleted the add-type-quote-patterns branch September 10, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky Awaiting requested review from odersky

Assignees

@odersky odersky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @odersky