Fix #5006: Normalize prefixes of TypeApply in Erasure #6888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will run the CI tests several times as the idempotency issue was non-deterministic. |
nicolasstucki
force-pushed
the
fix-#5006-2
branch
from
3ad8684 to
caea1bb
Compare
nicolasstucki
force-pushed
the
fix-#5006-2
branch
from
caea1bb to
499fae2
Compare
|
Note that |
|
OK but... what does it break and any idea why? :) |
|
Some nondeterministic code somewhere else make the position different. As far as I could tell it is just an issue with different positions for synthesized trees. |
|
I will investigate further after this PR |
smarter
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reverted in #6886 due to an idempotency test failure