Remove implicit tasty.Reflection synthesis
#6823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
remove-implicit-tasty-Reflection-synthesis
branch
3 times, most recently
from
708f94a to
8743198
Compare
Replaced by implicit `quoted.QuoteContext`
nicolasstucki
force-pushed
the
remove-implicit-tasty-Reflection-synthesis
branch
from
8743198 to
cc2c34b
Compare
|
Rebased |
liufengyun
approved these changes
Jul 10, 2019
| (formal, span) => implicit ctx => | ||
| if (ctx.inInlineMethod || enclosingInlineds.nonEmpty) ref(defn.TastyReflection_macroContext) | ||
| else EmptyTree | ||
|
|
There was a problem hiding this comment.
Is it too early to remove it? Or we may assume that if people are experimenting with new macros, they can tolerate such changes without a transition period?
There was a problem hiding this comment.
For most things we already require a QuoteContext with a stable path which this implicit conversion does not provide. Hence using Reflection may easily lead to confusing errors. Having a single way to do things will be clearer. This change also aims to align fully with the documentation and fail where the code is using a pattern that will probably not work at long terms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced by implicit
quoted.QuoteContext