Skip to content

Move macro error reporting to QuoteContext #6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

Add QuoteContext.{error, warning} and remove QuoteError exception.

@nicolasstucki nicolasstucki force-pushed the quote-error-on-quote-context branch from 0e7a1d5 to 6cc8d26 Compare July 8, 2019 14:31
Add `QuoteContext.{error, warning}` and remove `QuoteError` exception.
@nicolasstucki nicolasstucki force-pushed the quote-error-on-quote-context branch from 6cc8d26 to cfedcd8 Compare July 8, 2019 20:59
@nicolasstucki nicolasstucki marked this pull request as ready for review July 9, 2019 06:08
@nicolasstucki nicolasstucki requested a review from liufengyun July 9, 2019 06:08
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@nicolasstucki nicolasstucki merged commit 7c33774 into scala:master Jul 9, 2019
@nicolasstucki nicolasstucki deleted the quote-error-on-quote-context branch July 9, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants