Skip to content

Update macros to quote context #6768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Update macros to quote context #6768

merged 1 commit into from
Jul 3, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 30, 2019 •
edited
Loading

Update community build projects to use scala.quoted.QuoteContext for macros instead of scala.tasty.Reflection.

@nicolasstucki nicolasstucki force-pushed the update-macros-to-quote-context branch 3 times, most recently from 98456c3 to 38b3b11 Compare June 30, 2019 10:02
@nicolasstucki nicolasstucki added this to the 0.18 Tech Preview milestone Jun 30, 2019
@nicolasstucki nicolasstucki self-assigned this Jun 30, 2019
@nicolasstucki nicolasstucki removed this from the 0.18 Tech Preview milestone Jul 2, 2019
@nicolasstucki nicolasstucki force-pushed the update-macros-to-quote-context branch from 38b3b11 to 8315c95 Compare July 2, 2019 12:28
@nicolasstucki nicolasstucki force-pushed the update-macros-to-quote-context branch from 8315c95 to 237061b Compare July 2, 2019 12:29
@nicolasstucki nicolasstucki requested a review from liufengyun July 2, 2019 12:48
@nicolasstucki nicolasstucki marked this pull request as ready for review July 2, 2019 12:48
This was referenced Jul 2, 2019
Closed
Merged
liufengyun
liufengyun approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit e12ebdf into scala:master Jul 3, 2019
@liufengyun liufengyun deleted the update-macros-to-quote-context branch July 3, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun