Fix/#652 erase constructors #675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thsi was not true for erased typechecking.
This was one source of the "reference to this before super" errors.
Map references to outer accessors in secondary constructors to outer parameters. This was the second source of "reference to this before super call" errors.
|
Fixes #652 |
Proxy references in constructors can't be left as fields because they can happen before the supercall.
Previously this was only done in secondary constructors; need to do it in primary constructor as well to avoid "reference to this before super" problems.
|
Now fixes also #644 |
Only outer references that point to the same class as the outer parameter should be mapped. Other outer references should be left alone. Such references can appear after the initial supercall of a constructor.
Difference was in generated number for anonymous classes only.
We seem to have an instability where the testing framework influences what numbers anonymous classes are given. We have to deal with this, but not now. For the moment I am masking numbers from the test output.
Ws disabled by accident.
|
Hmm, how do I get the original PR back? |
|
I'll do a second branch. |
|
Otherwise LGTM. No need to revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several problems detected and fixed when trying to compile constructors.scala. These are all pretty fundamental, and therefore a version of the PR should be merged before we try to continue with the bootstrap. Review by @DarkDimius.