Add quoted.Expr.block #6747
Merged
Add quoted.Expr.block #6747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a constructor for block expression that creates the block from a list of expression. The other way to crreate blocks is by nesting blocks in a recursion which is prone stack overflows.
liufengyun
approved these changes
Jun 26, 2019
| import refl._ | ||
| Block(statements.map(_.unseal), expr.unseal).seal.asInstanceOf[Expr[T]] | ||
| } | ||
|
|
There was a problem hiding this comment.
It seems this can be done using toExprList and then use quote and splices?
There was a problem hiding this comment.
Functionally it can but it would not solve the recursion issue. But actually I could use this one to improve toExprOfList
There was a problem hiding this comment.
By improve I mean not have a recursive implementation that nests all the trees creating an extremely deep tree.
There was a problem hiding this comment.
I hit a bug trying to implement it. I will leave it for another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a constructor for block expression that creates the block from a list of expression.
The other way to crreate blocks is by nesting blocks in a recursion which is prone stack overflows.