Add Support of Parsing Runtime Invisible Annotations to Classfile Parser #6731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jun 23, 2019
smarter
reviewed
Jun 23, 2019
| parseAnnotations(attrLen) | ||
|
|
||
| // TODO 1: parse runtime visible annotations on parameters | ||
| // case tpnme.RuntimeParamAnnotationATTR | ||
|
|
||
| // TODO 2: also parse RuntimeInvisibleAnnotation / RuntimeInvisibleParamAnnotation, |
There was a problem hiding this comment.
This TODO also exists in Scala 2 (https://github.com/scala/scala/blob/ec46ff84333501bd11c8cac89802508d580c470d/src/compiler/scala/tools/nsc/symtab/classfile/ClassfileParser.scala#L859). @retronym : any idea why these annotations have never been parsed so far ?
There was a problem hiding this comment.
No good reason that I'm aware of. I agree we should parse these and give then StaticAnnotation parent.
|
test performance please |
|
@liufengyun looks like the benchmarking bot isn't responding ? ^ |
smarter
approved these changes
Jun 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support of parsing runtime invisible annotations to
ClassfileParser.For the explicit-nulls project, we want to read
NotNullannotations of Java methods to generate better types. Originally, dotc was only able to parseRuntimeVisibleAnnotationsin Classfile. However, someNotNullannotations are runtime invisible (RuntimeInvisibleAnnotations).Since both annotations have the same structure, this PR only changes two parts:
Rename Classfile Attributes in
StdNames.scalaAdd
RuntimeInvisibleAnnotationsattribute toClassfileParser.scala