Refactor viewExists #673
Merged
Refactor viewExists #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out isValueSubClass into separate method. Will probably come in handly elsewhere, and makes the code easier to understand.
Merged
| @@ -601,6 +601,19 @@ object Types { | |||
| ctx.typeComparer.isSameType(this, that) | |||
| } | |||
|
|
|||
| /** Is this type a primitive value type which can be widened to the primitive value type `to`? */ | |||
|
Otherwise LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out isValueSubClass into separate method. Will probably come in handly
elsewhere, and makes the code easier to understand.
Review by @DarkDimius