Fix #6710: reverse code for dcmpg/dcmpl and fcmpg/fcmpl #6722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the test may only run with the bootstrapped compiler, because the ConstFold in non-bootstrapped compiler is using the wrongly generated byte-code.
odersky
reviewed
Jun 21, 2019
|
Scalac has similar regression, which was fixed in scala/scala#5207 . The tests there were already included in this PR. /cc: @lrytz Could you please advise if this is the proper fix? |
odersky
approved these changes
Jun 22, 2019
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 22, 2019
The two branches are currently dead code, as we never call `genCZJUMP` with tk = DOUBLE or FLOAT. However, in case the two branches become reachable, it's good to make the logic consistent as in `genCJUMP` (scala#6722).
odersky
added a commit
that referenced
this pull request
Jun 26, 2019
Follow up to #6722: make dead code consistent in handling NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the test may only run with the bootstrapped compiler,
because the ConstFold in non-bootstrapped compiler is using
the wrongly generated byte-code.