Update ScalaTest to the latest scalatest/3.1.x branch #6704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
requested changes
Jun 18, 2019
There was a problem hiding this comment.
It looks like this PR reenables the tests in FutureSugarSpec that were disabled in dotty-staging/scalatest@d3e01c1 and dotty-staging/scalatest@40fc91f because of timeouts. I suggest cherry-picking these commits in this branch, or alternatively changing the scalatest tests to increase the timeout for async tests.
|
Proposed a PR to disable the test here: scalatest/scalatest#1607 |
liufengyun
force-pushed
the
update-scalatest
branch
from
51eb42a to
3702eca
Compare
|
The tests in |
nicolasstucki
approved these changes
Jun 26, 2019
smarter
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ScalaTest to the latest scalatest/3.1.x branch