Correct small typo in macros example #6690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Jun 15, 2019
|
@stevenheidel you will need to sign the CLA at https://www.lightbend.com/contribute/cla/scala. Otherwise the changes look good to me. |
|
Change looks good @stevenheidel! Thanks! I noticed your other PRs. We usually try to contain changes as a unit of work. I think we can merge these now but next time it would be more convenient if you would contain all relevant changes (e.g., Fixes at docs) as one PR. A draft PR is preferable if you have work in progress! Despite this, a big thanks that you took the time to have a look and make the fixes 🎉 |
|
Will do in the future, thanks. Also I just signed the CLA 👍 |
nicolasstucki
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction 2 of 3 that I found while reading the docs last night.