Re-introduce java.lang.Enum constructor hijack. #6624
Conversation
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
But this time do it lazily, by installing a special completer.
| @@ -614,6 +614,33 @@ class Definitions { | |||
| JavaSerializableClass.typeRef | |||
| else | |||
| ctx.requiredClassRef("scala.Serializable") | |||
|
|
|||
| @threadUnsafe lazy val JavaEnumClass: ClassSymbol = { | |||
| val cls = ctx.requiredClass("java.lang.Enum") | |||
There was a problem hiding this comment.
ping @sjrd, this might interact with Scala.js reimplementation of Enum: https://github.com/scala-js/scala-js/blob/master/javalanglib/src/main/scala/java/lang/Enum.scala
There was a problem hiding this comment.
Also it'd be nice to add a comment explaining why this hijacking is necessary.
There was a problem hiding this comment.
Hum, it's unclear how that would interact with the Scala.js implementation, indeed. However, that's not an immediate problem, because for now Dotty.js reuses the binaries of java.lang.Enum.sjsir from Scala.js for scalac.
Worse come to worst, we would hard-code the .sjsir of java.lang.Enum in the distant future where we can actually compile Scala.js' standard library with Dotty.js.
|
@anatoliykmetyuk Please rebase your changes to enums on top of this. |
But this time do it lazily, by installing a special completer.