Skip to content

Use TupledFunction for Expr.FunctionBetaReduction #6618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki force-pushed the improve-quoted-expr-FunctionBetaReduction branch from 5224871 to 14b4149 Compare June 6, 2019 08:36
@nicolasstucki nicolasstucki changed the title Support Expr.FunctionBetaReduction for all arities Use TupledFunction for Expr.FunctionBetaReduction Jun 6, 2019
@nicolasstucki nicolasstucki marked this pull request as ready for review June 6, 2019 09:34
@nicolasstucki nicolasstucki requested a review from odersky June 6, 2019 09:34
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call FunctionBetaReduction, AsFunction? That's what it is, effectively, no?

@nicolasstucki
Copy link
Contributor Author

Yes, I can rename it.

@nicolasstucki nicolasstucki merged commit 3c591ed into scala:master Jun 6, 2019
@nicolasstucki nicolasstucki deleted the improve-quoted-expr-FunctionBetaReduction branch June 6, 2019 19:20
@odersky
Copy link
Contributor

odersky commented Jun 6, 2019

OK, then we just need to do minor adaptations in macros.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants