Fix #5597: Remove scala-xml dependency, add it to the community-build #6595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
remove-xml
branch
4 times, most recently
from
169dc14 to
e1d6a3e
Compare
|
Pending scalatest PR: scalatest/scalatest#1599 |
smarter
force-pushed
the
remove-xml
branch
4 times, most recently
from
98150ce to
56b33ee
Compare
…build This means that our test suites can no longer contain xml tests, instead they need to be added to scala-xml like this: scala/scala-xml@9762438
smarter
force-pushed
the
remove-xml
branch
2 times, most recently
from
6fd2811 to
117359c
Compare
This is similar to what Scala 2 does.
This lead to runtime errors when running `scalatestTestDotty/test` in scalatest, because scalatest depends on a different version of flexmark. I'm not sure why these jars leaked into the runtime classpath (might be an sbt bug) but it seems better to limit the compiler classpath to the minimum needed anyway, so we now only add the dotty-doc dependencies when running the `doc` task.
Previously this failed because we picked multiple jars when we were only excepting the binary jar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that our test suites can no longer contain xml tests, instead
they need to be added to scala-xml like this:
scala/scala-xml@9762438