Refactor FlagSet #6562
Merged
Refactor FlagSet #6562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
odersky
changed the title
odersky
force-pushed
the
refactor-flags
branch
3 times, most recently
from
34040f9 to
7e9d71d
Compare
OlivierBlanvillain
approved these changes
May 29, 2019
compiler/src/dotty/tools/backend/jvm/DottyBackendInterface.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/TransformByNameApply.scala
Outdated
Show resolved
Hide resolved
OlivierBlanvillain
force-pushed
the
refactor-flags
branch
from
72b7d5f to
d41bd9a
Compare
odersky
force-pushed
the
refactor-flags
branch
2 times, most recently
from
112783f to
c475cbf
Compare
odersky
force-pushed
the
refactor-flags
branch
2 times, most recently
from
f66b17e to
b7aeb2b
Compare
|
I am going to merge this tomorrow since it is mostly cosmetic. It would be a pain to review. |
This is in preparation of making Flags an opaque type
and don't overload `is`. FlagConjunction tests are now called `isAll`.
Also rename SymDenotaton.is(_, _) to isAllOf
Drop .toFlags conversion
Make FlagSet an opaque type and all flag ops extension methods
This is achieved by creating a new opaque type `Flag` that represents a single flag.
Todo: Should do the same in Tasty reflect
Where it makes sense, flag combinations have been renamed to follow their alphabetically ordered definitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isinto three methods:isOneOf,isAllOftaking aFlagSetandistaking a singleFlag.