Make Vulpix checkfiles identical to the actual console output #6508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoliykmetyuk
force-pushed
the
vulpix-checkfiles-identical
branch
from
db0498d to
55cdd21
Compare
nicolasstucki
suggested changes
May 15, 2019
| @@ -686,7 +685,9 @@ trait ParallelTesting extends RunnerOrchestration { self => | |||
|
|
|||
| def getMissingExpectedErrors(errorMap: HashMap[String, Integer], reporterErrors: Iterator[MessageContainer]) = !reporterErrors.forall { error => | |||
| val key = if (error.pos.exists) { | |||
| val fileName = error.pos.source.file.toString | |||
| def toRelative(path: String): String = // For some reason, absolute paths leak from the compiler itself... | |||
There was a problem hiding this comment.
It is worth figuring out where they come from and why. Could or should they already be relative? This is a separate issue.
There was a problem hiding this comment.
Technically, both relative and absolute paths are correct ways to point to a file. If the compiler at some point converts relative paths to absolute ones, I don't think it is an issue.
There was a problem hiding this comment.
That can be an issue. For example .tasty files contain a path to the file which will be published. This path must be relative or any tool that consumes them will be lost.
anatoliykmetyuk
force-pushed
the
vulpix-checkfiles-identical
branch
from
55cdd21 to
7924421
Compare
nicolasstucki
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.