Allow given in constructor applications
#6488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far pathTo(span) would only guarantee to return the path to the closest tree enclosing `span` if trees were non-overlapping. This is property does not hold for typed trees, yet `pathTo` is called from `Interactive` on such typed trees. This commit makes `pathTo` work correctly also for overlapping trees.
With given coming last, some of the no-overlaps and in-order position checks have to be weakened. But with the more generalized pathTo implementation, non-overlapping and in-order is not really needed anymore.
They printed as normal arguments before.
The previous syntax was unparseable without major contortions in the Parser.
|
I tried the following: class C2(val n: Int) given List[TC] extends AnyVal and I got what I expected: Maybe we need to fine tune this error message. What do you think? Otherwise looks good. |
biboudis
approved these changes
May 16, 2019
I agree there's room for improvement, but it's not urgent. What one could do is add a note to the error message saying that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6486.