Skip to content

Smooth logo animation #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2019
Merged

Smooth logo animation #6473

merged 2 commits into from
May 8, 2019

Conversation

Jentsch
Copy link
Contributor

@Jentsch Jentsch commented May 7, 2019

The animation of the logo on the index page was triggered by JavaScript. Even on a fast device the full logo was visible before the animation started. A simple replacement written in CSS is much smoother, because it doesn't wait for document ready.

Also I removed scrollreveal.js and animate.css, because I found no place where they are still used. Saves some bytes.

Jentsch added 2 commits May 7, 2019 23:47
Allows a smoother animation during load.
Remove scrollreveal.js, since this was the only usage.
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@odersky odersky merged commit 9ed471c into scala:master May 8, 2019
@Jentsch Jentsch deleted the smooth-logo-animation branch May 8, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants