Skip to content

Improve runtime crashes when using -Xignore-scala2-macros #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2019
Merged

Improve runtime crashes when using -Xignore-scala2-macros #6463

merged 1 commit into from
May 6, 2019
+1 −1

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 6, 2019 •
edited
Loading

Ensure that the crash due to the missing Scala 2 macro does give some meaningful feedback

@nicolasstucki nicolasstucki requested a review from liufengyun May 6, 2019 08:44
@nicolasstucki
Copy link
Contributor Author

nicolasstucki commented May 6, 2019 •
edited
Loading

Bonus: references with @compileTimeOnly in macro arguments will not fail under -Xignore-scala2-macros

liufengyun
liufengyun approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit b34ea5d into scala:master May 6, 2019
@nicolasstucki nicolasstucki deleted the improve-runtime-crashes-when-using-Xignore-scala2-macros branch May 6, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun