Fix #5039: Handle null:_* as varargs parameter #6418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
commented
May 2, 2019
| @@ -556,6 +556,8 @@ trait Applications extends Compatibility { self: Typer with Dynamic => | |||
| args match { | |||
| case arg :: Nil if isVarArg(arg) => | |||
| addTyped(arg, formal) | |||
| case Typed(Literal(Constant(null)), _) :: Nil => | |||
| addTyped(args.head, formal) | |||
There was a problem hiding this comment.
Note that I used .head because args is of type List[Arg] and
case (arg @ Typed(Literal(Constant(null)), _)) :: Nil =>
addTyped(arg, formal)would fail with
[error] 560 | addTyped(arg, formal)
[error] | ^^^
[error] |Found: dotty.tools.dotc.ast.Trees.Typed[dotty.tools.dotc.ast.Trees.Untyped](arg)
[error] |Required: Arg
There was a problem hiding this comment.
What about just reject the code? We are moving towards null-safety, it seems it's better to reject. /cc: @abeln
There was a problem hiding this comment.
We should not always reject it. We could pass it to a Java varargs. Not sure if someone actually uses this pattern for performance reasons.
There was a problem hiding this comment.
In Java it is legal to pass null as the actual array of the varargs https://coderanch.com/t/631441/java/Varargs-null
|
We fix the crash with this PR. We can add new null safety checks later when we integrate non billable types |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.