Fix #6403: Do not intercept crashes #6408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-#6403
branch
from
5c68e1f to
ab42b4d
Compare
smarter
approved these changes
Apr 30, 2019
nicolasstucki
changed the title
|
The printed message might be swallowed by the test framework. It feels more resilient to wrap them. |
Emitting an error when the backend crashes hides the crash from the reporter and fails which cannot be identified by the testing framework.
|
Now it prints the extra message and throws the original exception |
smarter
approved these changes
May 1, 2019
compiler/src/dotty/tools/backend/jvm/DottyBackendInterface.scala
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emitting an error when the backend crashes hides the crash from the reporter and fails which cannot be identified by the testing framework.