Do not rename names starting with $ in quoted patterns
#6347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we renamed `val $a` to `val a` and at the same time created a binding
named `a`. A reference to `a` inside a splice could not be disambiguated.
```scala
case '{ val $a: Int = 4; `$a` + ${ ... a ... '{ .. `$a` .. } ... } } => a
```
This change allows us to both refer to the `a` binding and the `$a` reference inside splices without ambiguities.
odersky
approved these changes
Apr 21, 2019
|
Yes, we still depend on quoted ValDef and DefDef during desugaring. |
Let's try to get rid of this in a separate PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we renamed
val $atoval aand at the same time created a bindingnamed
a. A reference toainside a splice could not be disambiguated.This change allows us to both refer to the
abinding and the$areference inside splices without ambiguities.