Add spec for quoted patterns #6334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-quoted-patterns-spec
branch
from
6d1cec1 to
484ffc2
Compare
nicolasstucki
force-pushed
the
add-quoted-patterns-spec
branch
from
484ffc2 to
ef107bf
Compare
liufengyun
approved these changes
May 1, 2019
There was a problem hiding this comment.
LGTM
As discussed with @nicolasstucki , this is WIP and will be updated in the following PRs. It's will be more productive if this is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the current spec of
scala.internal.quoted.Matcher.unapply. This is intended to reflect the current state and not the spec that we want to have at the end.