Test Only: Revert interpolateTypeVars fix #6333
Conversation
There seemed to have been a large performance regression due to its recent changes. Let's find out whether that's really the case.
Just to see whether this indeed brings performance back to the previous levels.
There was a problem hiding this comment.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Commit Messages
We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).
Please stick to these guidelines for commit messages:
- Separate subject from body with a blank line
- When fixing an issue, start your commit message with
Fix #<ISSUE-NBR>:- Limit the subject line to 72 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line ("Add" instead of "Added")
- Wrap the body at 80 characters
- Use the body to explain what and why vs. how
adapted from https://chris.beams.io/posts/git-commit
Have an awesome day! ☀️
|
test performance please |
|
performance test scheduled: 3 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6333/ to see the changes. Benchmarks is based on merging with master (f09550d) |
|
test performance please |
|
performance test scheduled: 2 job(s) in queue, 1 running. |
|
Wow, impressive. So it was that change and the benchmarks were telling the truth! |
| @@ -412,7 +412,7 @@ trait Inferencing { this: Typer => | |||
| // `qualifying`. | |||
|
|
|||
| val ownedVars = state.ownedVars | |||
| if (ownedVars.size > 0) { | |||
| if (ownedVars.size > locked.size) { | |||
There was a problem hiding this comment.
This seems to be a miracle -- how this change could have such a big impact on performance.
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/6333/ to see the changes. Benchmarks is based on merging with master (58d5dca) |
No description provided.