Skip to content

Fix #6325: Propagate error type to internal splice #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 18, 2019
Merged

Fix #6325: Propagate error type to internal splice #6326

merged 2 commits into from
Apr 18, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki self-assigned this Apr 17, 2019
@nicolasstucki
Fix scala#6324: Emit error when pattern splice prototype is not fully…
c5251ea 
… defined

Previously it was an assertion which crashed the compilation
@nicolasstucki nicolasstucki marked this pull request as ready for review April 17, 2019 11:50
@nicolasstucki nicolasstucki mentioned this pull request Apr 17, 2019
Closed
liufengyun
liufengyun approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki merged commit 58d5dca into scala:master Apr 18, 2019
@ghost ghost removed the stat:needs review label Apr 18, 2019
@nicolasstucki nicolasstucki deleted the fix-#6325 branch April 18, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun