Make inline non final #6316
Merged
Make inline non final #6316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Calling this an override seams misleading given that the (presumably) overridden implementation is still available: b.f1() // Expends the macro defined in B
(b: A).f1() // Expends the macro defined in A |
|
@OlivierBlanvillain I'd say that's just the difference between static and dynamic binding. |
odersky
approved these changes
Apr 17, 2019
This change is to support macro overrides
nicolasstucki
force-pushed
the
make-inline-non-final
branch
from
fb4eb52 to
f6e0238
Compare
|
Rebased |
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support macro overrides