Don't emit inner classes as static classes #6268
Merged
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`isOriginallyStaticOwner` did the wrong thing and return true for pretty much any class (because after LambdaLift, all classes are top-level, so they're always static), this had no effect on Scala code but prevented Java code from instantiating these classes. The new implementation is identical to the one used in scalac and matches the documentation comment for the method. This allows t10889 from scala/scala#7975 to pass.
nicolasstucki
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isOriginallyStaticOwnerdid the wrong thing and return true for prettymuch any class (because after LambdaLift, all classes are top-level, so
they're always static), this had no effect on Scala code but prevented
Java code from instantiating these classes.
The new implementation is identical to the one used in scalac and
matches the documentation comment for the method.
This allows t10889 from scala/scala#7975 to
pass.