Cleanup and document Tasty format #6267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
reviewed
Apr 9, 2019
| ImplicitArg = IMPLICITARG arg_Term | ||
| ASTRef = Nat // byte position in AST payload | ||
| Param = PARAM Length NameRef type_Term rhs_Term? Modifier* -- modifiers name : type (= rhs_Term)?. `rhsTerm` is present in the case of an aliased class parameter | ||
| Template = TEMPLATE Length TypeParam* Param* parent_Term* Self? Stat* -- [typeparams] paramss extends parents { self => stats }, where Stat* always starts with the primary constructor. |
There was a problem hiding this comment.
This should be Params*, I think.
smarter
reviewed
Apr 9, 2019
| ERASEDMETHODtype Length result_Type NamesTypes -- A method type `erased (NamesTypes)result`, needed for refinements | ||
| GIVENMETHODtype Length result_Type NamesTypes -- A method type `given (NamesTypes)result`, needed for refinements | ||
| ERASEDGIVENMETHODtype Length result_Type NamesTypes -- A method type `given erased (NamesTypes)result`, needed for refinements | ||
| IMPLCITMETHODtype Length result_Type NamesTypes -- A method type `(implicit NamesTypes)result`, needed for refinements |
There was a problem hiding this comment.
Suggested change
| IMPLCITMETHODtype Length result_Type NamesTypes -- A method type `(implicit NamesTypes)result`, needed for refinements | |
| IMPLICITMETHODtype Length result_Type NamesTypes -- A method type `(implicit NamesTypes)result`, needed for refinements |
It was not supported yet by pickler and unpickler. In fact it would be quite awkward to support it since in the pickling format a symbol reference is the address of the definition tree node. So if there is only a single OBJECTDEF node, we get an ambiguity between object and its module class. This makes tree unpickling much harder. So I believe it is better to expose the object encoding into a lazy val and a class definition. That also explains where OBJECTNAMEs are bound.
odersky
force-pushed
the
change-tasty-std
branch
from
b1fd0f7 to
613a355
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.